Allow to cancel connecting #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 4 28 +24
Lines 26 995 +969
Branches 0 148 +148
======================================
- Misses 26 995 +969 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adietish
force-pushed
the
allow-cancel--connecting
branch
from
6f4c481 to
1ca6c72
Compare
msivasubramaniaan
requested changes
Sep 8, 2025
|
|
||
| ProgressManager.getInstance().runProcessWithProgressSynchronously( | ||
| { | ||
| val indicator = ProgressManager.getInstance().progressIndicator |
There was a problem hiding this comment.
variable indicator is unused
Signed-off-by: Andre Dietisheim <[email protected]>
adietish
force-pushed
the
allow-cancel--connecting
branch
from
1ca6c72 to
91d2247
Compare
|
@msivasubramaniaan corrected, please re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows up on #162
depends on #165 which has to be merged first