Skip to content

Conversation

themr0c
Copy link
Member

@themr0c themr0c commented Sep 9, 2025

Addendum to #1348 addressing comments posted after the merge.

Version(s): 1.7

Issue: https://issues.redhat.com/browse/RHDHBUGS-2005

Preview:

Signed-off-by: Fabrice Flore-Thébault <[email protected]>
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Sep 9, 2025

Signed-off-by: Fabrice Flore-Thébault <[email protected]>
@themr0c themr0c changed the title Used the product attribute consistently RHDHBUGS-2005 Fixed broken links addendum Sep 9, 2025
@themr0c
Copy link
Member Author

themr0c commented Sep 9, 2025

/cherry-pick release-1.7

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@jmagak jmagak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, @themr0c.

Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
@themr0c themr0c merged commit 10beaba into redhat-developer:main Sep 9, 2025
3 checks passed
@themr0c themr0c deleted the RHDHBUGS-2005-addendum branch September 9, 2025 13:28
@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: #1359 failed to apply on top of branch "release-1.7":

Applying: Used the product attribute consistently
error: patch failed: modules/release-notes/ref-release-notes-new-features.adoc:81
error: modules/release-notes/ref-release-notes-new-features.adoc: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Using index info to reconstruct a base tree...
A	modules/installation/proc-install-create-custom-flavor.adoc
M	modules/release-notes/ref-release-notes-new-features.adoc
Patch failed at 0001 Used the product attribute consistently

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

themr0c added a commit to themr0c/red-hat-developers-documentation-rhdh that referenced this pull request Sep 9, 2025
jmagak pushed a commit to themr0c/red-hat-developers-documentation-rhdh that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants