Skip to content

Fix RDBX_writeFromCmdNumber() option and filtering #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix RDBX_writeFromCmdNumber() option and filtering #80

wants to merge 1 commit into from

Conversation

moticless
Copy link
Collaborator

  • Fixed --start-cmd-num short option from -n to -s as expected.
  • Fixed command filtering to properly handle RDB_OK_DONT_PROPAGATE when skipping commands

tezc
tezc reviewed Sep 18, 2025
View reviewed changes
src/cli/rdb-cli.c
if (getOptArg(argc, argv, &at, "-t", "--target-redis-ver", NULL, &(conf.dstRedisVersion))) continue;
if (getOptArgVal(argc, argv, &at, "-l", "--pipeline-depth", NULL, &pipeDepthVal, 1, 1000)) continue;
if (getOptArgVal(argc, argv, &at, "-n", "--start-cmd-num", NULL, &startCmdNum, 1, INT_MAX)) continue;
if (getOptArgVal(argc, argv, &at, "-s", "--start-cmd-num", NULL, &startCmdNum, 1, INT_MAX)) continue;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/redis/librdb/pull/79/files

in this PR, you change help string to -n but here it goes back to -s? no ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tezc tezc tezc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moticless @tezc