Skip to content

Support new PR view in isClosedIssue; tighten related checks #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Support new PR view in isClosedIssue; tighten related checks #201

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4f915d5
Refactor PR state selectors and add checks for PR and issue types
kovsu Nov 6, 2024
7d6a488
update
kovsu Nov 6, 2024
cbad3da
update
kovsu Nov 6, 2024
efb1f7d
update
kovsu Nov 6, 2024
fcc805f
update
kovsu Nov 6, 2024
e3aa162
lint
kovsu Nov 6, 2024
156bdf1
update
kovsu Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,28 +286,40 @@ TEST: addTests('isQuickPR', [
'https://github.com/sindresorhus/refined-github/compare/test-branch?quick_pull=1',
]);

const prStateSelector = [
const stateSelector = [
'.State',
'[class^="StateLabel"]',
'[data-testid="header-state"]',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-testid is already gone :(

Test URL: https://github.com/refined-github/refined-github/pull/7987/commits

Screenshot

Copy link
Member

@fregante fregante Nov 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

].join(',');

export const isDraftPR = (): boolean => $(prStateSelector)!.textContent!.trim() === 'Draft';
export const isDraftPR = (): boolean => $(stateSelector)?.textContent!.trim() === 'Draft';
export const isOpenPR = (): boolean => {
const status = $(prStateSelector)!.textContent!.trim();
if (!isPR()) {
return false;
}

const status = $(stateSelector)!.textContent!.trim();
return status === 'Open' || status === 'Draft';
};

export const isMergedPR = (): boolean => {
const status = $(prStateSelector)!.textContent!.trim();
return status === 'Merged';
};
export const isMergedPR = (): boolean => $(stateSelector)?.textContent!.trim() === 'Merged';

export const isClosedPR = (): boolean => {
const status = $(prStateSelector)!.textContent!.trim();
if (!isPR()) {
return false;
}

const status = $(stateSelector)!.textContent!.trim();
return status === 'Closed' || status === 'Merged';
};

export const isClosedIssue = (): boolean => exists('#partial-discussion-header :is(.octicon-issue-closed, .octicon-skip)');
export const isClosedIssue = (): boolean => {
if (!isIssue()) {
return false;
}

const status = $(stateSelector)!.textContent!.trim();
return status === 'Closed' || status === 'Closed as not planned';
};

export const isReleases = (url: URL | HTMLAnchorElement | Location = location): boolean => getRepo(url)?.path === 'releases';
TEST: addTests('isReleases', [
Expand Down
Loading