Update translations #106
Update translations #106
Conversation
WalkthroughThe changes update localization files for English and Dutch. In English, the "PROPERTIES_HELP_TEXT" structure is changed from an array to an object with a numeric string key. In Dutch, several new translation entries are added, capitalization is adjusted for "NOTE", and UI-related keys for pages, PDF, popups, and settings are introduced. Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
| lint rule | new reports | level | link |
|---|---|---|---|
| Identical pattern | 3 | warning | contribute (via Fink 🐦) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
en/all.json(1 hunks)nl/all.json(2 hunks)
🔇 Additional comments (5)
nl/all.json (5)
21-22: Approved: Lowercase note translations for consistency
Changing"Notitie"/"Notities"to lowercase"notitie"/"notities"aligns with the English source ("note"/"notes") and maintains consistency.
86-94: Verify completeness of new PAGES > ALL_NOTES > SORT translations
The English file includes additional sort options (BY_CREATION_TIME,BY_MODIFICATION,BY_TITLE,OLDEST_FIRST,RECENTLY_MODIFIED) underPAGES.ALL_NOTES.SORT. Please confirm whether onlyASCENDINGandDESCENDINGwere intended, or if the full set of sort keys should be added here.
95-99: Approved: Translate PDF note button tooltip
The translation ofNOTE_BTN_TOOLTIPto"Opmerking"accurately conveys the functionality.
100-106: Approved: Popup DOCUMENT title translation
The popup title"Document"matches the English key and is correctly translated.
107-116: Approved: Add SETTINGS > ACCOUNT navigation and support translations
The translations forNAVIGATION_TITLE,SUPPORT.TITLE, andVERSION.KEYWORDSare accurate and consistent.
| "PROPERTIES_HELP_TEXT": { | ||
| "0": "Properties describe a tag. For example, for a tag called \"Book\", add properties named Author, Genre, Reading Status, and more!" | ||
| }, |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Critical: Ensure PROPERTIES_HELP_TEXT structure is mirrored across locales
The English localization switched PROPERTIES_HELP_TEXT from an array to an object; this structural change must be reflected in all other locale files (e.g., Dutch) to avoid runtime mismatches in the translation loader.
Do you want me to generate a diff to update the corresponding entry in nl/all.json?
🏁 Script executed:
#!/bin/bash
echo "Searching for PROPERTIES_HELP_TEXT in all JSON locale files:"
rg -n '"PROPERTIES_HELP_TEXT"' -A5 --glob '*.json'Length of output: 4931
🏁 Script executed:
#!/bin/bash
echo "Listing all locale directories containing an all.json file:"
for d in */; do
if [ -f "${d}all.json" ]; then
echo "- ${d%/}"
fi
done
echo ""
echo "Checking for locale directories missing PROPERTIES_HELP_TEXT:"
for d in */; do
if [ -f "${d}all.json" ]; then
if ! grep -q '"PROPERTIES_HELP_TEXT"' "${d}all.json"; then
echo "- ${d%/}"
fi
fi
doneLength of output: 2788
Missing PROPERTIES_HELP_TEXT in multiple locales – please add the new entry
The English JSON moved PROPERTIES_HELP_TEXT from an array to an object, but the following locale files are still missing that key and will break at runtime:
- fa/all.json
- fr/all.json
- ka/all.json
- nl/all.json
- vi/all.json
Please add this snippet (using the proper translated string) at the same position as in en/all.json (just before PROPERTY_WITH_COUNT_one) in each file. For example, in nl/all.json:
@@ -779,6 +779,10 @@
"PROPERTIES_HELP_TEXT": {
- "0": "…old array entry…"
+ "0": "Properties describe a tag. For example, for a tag called \"Book\", add properties named Author, Genre, Reading Status, and more!"
},
"PROPERTY_WITH_COUNT_one": "{{count, number}} Eigenschap",Let me know if you’d like diffs for the other locales as well.
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In en/all.json around lines 779 to 781, the PROPERTIES_HELP_TEXT key was changed
from an array to an object. To prevent runtime errors, update the corresponding
PROPERTIES_HELP_TEXT entry in all other locale files (fa/all.json, fr/all.json,
ka/all.json, nl/all.json, vi/all.json) to match this new object structure.
Insert the new key-value pair at the same position as in en/all.json, just
before PROPERTY_WITH_COUNT_one, using the appropriate translated string for each
locale.
1 participant
Added some NL translations.
Preview the messages on https://inlang.com/github.com/danieleristori/translation .
Summary by CodeRabbit
New Features
Style
Chores