feat: pos client #38
Closed
feat: pos client #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| private setupEventHandlers = () => { | ||
| this.on("await_approval", async ({ approval, intentId }) => { | ||
| try { | ||
| console.log("await_approval", intentId); |
There was a problem hiding this comment.
Bug: Redundant Check and Debugging Logs
The awaitPaymentConfirmed method includes a redundant if (transactionResult) { break; } check within its while (!transactionResult) loop, as the while condition already ensures transactionResult is falsy on entry. Additionally, several console.log statements appear to be debugging code that was committed and could be removed or replaced with a proper logging solution.
Member
Author
|
closing in favour of WalletConnect/walletconnect-monorepo#6912 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How has this been tested?
tests
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.