Skip to content

Improve moveByCharacter for rtl text #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −0
Open

Improve moveByCharacter for rtl text #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/vim.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,23 @@ export function initVim(CM) {
*/
var langmap = parseLangmap('');

function isRtlLine(line) {
for (let i = 0; i < line.length; i++) {
const char = line[i];
const code = char.charCodeAt(0);

// Only care about letter characters, skip spaces, numbers, punctuation
if (/\p{L}/u.test(char)) {
// If it's a letter, check if it's NOT in RTL range
if (code < 0x0590 || code > 0x07FF) {
return false; // Found a non-RTL letter
}
}
}

return true; // No non-RTL letters found
}

/** @arg {CodeMirror} cm */
function enterVimMode(cm) {
cm.setOption('disableInput', true);
Expand Down Expand Up @@ -2385,6 +2402,13 @@ export function initVim(CM) {
moveByCharacters: function(_cm, head, motionArgs) {
var cur = head;
var repeat = motionArgs.repeat;

// if the all text is right-to-left text, flip the direction
var rtlText = isRtlLine(_cm.getLine(cur.line));
if (rtlText) {
repeat = -repeat;
}

var ch = motionArgs.forward ? cur.ch + repeat : cur.ch - repeat;
return new Pos(cur.line, ch);
},
Expand Down