fix(storage/git): Make git sync untracked work with sqlite. #7822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of the sync untracked feature would attempt to run multiple queries in parallel. The `knex` framework appears to use a separate connection for each query by default (unless the queries are tied together by a transaction). When using sqlite, there is only a single connection available in the knex database pool, causing this feature to deadlock (when the initial query can not return all results immediatly). In this change, we switch to doing all of these queries in a transaction, which causes all quries to occur on a single connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of the sync untracked feature would attempt to run multiple queries in parallel. The
knexframework appears to use a separate connection for each query by default (unless the queries are tied together by a transaction). When using sqlite, there is only a single connection available in the knex database pool, causing this feature to deadlock (when the initial query can not return all results immediatly).In this change, we switch to doing all of these queries in a transaction, which causes all quries to occur on a single connection.