Skip to content

Fix socket CLOSE_WAIT error in tunnel agent #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix socket CLOSE_WAIT error in tunnel agent #21

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abecbfe
destroy socket when error
mike442144 Nov 22, 2016
b4ce7b8
callback even if connect response statuscode is not 200
mike442144 Dec 15, 2016
02c90a4
fix close_wait bug
mike442144 Dec 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
'use strict'
'use strict'

var net = require('net')
, tls = require('tls')
Expand Down Expand Up @@ -154,18 +154,18 @@ TunnelingAgent.prototype.createSocket = function createSocket(options, cb) {
function onConnect(res, socket, head) {
connectReq.removeAllListeners()
socket.removeAllListeners()
self.sockets[self.sockets.indexOf(placeholder)] = socket

if (res.statusCode === 200) {
assert.equal(head.length, 0)
debug('tunneling connection has established')
self.sockets[self.sockets.indexOf(placeholder)] = socket
cb(socket)
} else {
debug('tunneling socket could not be established, statusCode=%d', res.statusCode)
var error = new Error('tunneling socket could not be established, ' + 'statusCode=' + res.statusCode)
error.code = 'ECONNRESET'
options.request.emit('error', error)
self.removeSocket(placeholder)
cb(socket)
options.request.emit('error', error) // fire up error on ClientRequest.
}
}

Expand Down