Skip to content

Conversation

nikrooz
Copy link
Contributor

@nikrooz nikrooz commented Jul 30, 2025

We should not merge/publish this, until we updated docs and examples.

Signed-off-by: Nik Nasr <[email protected]>

add serve

Signed-off-by: Nik Nasr <[email protected]>

move endpoint builder

Signed-off-by: Nik Nasr <[email protected]>

update test environments

Signed-off-by: Nik Nasr <[email protected]>

update cloudflare fetch

Signed-off-by: Nik Nasr <[email protected]>

add patch to cloudflare

Signed-off-by: Nik Nasr <[email protected]>
Copy link

Test Results

  7 files  ±0    7 suites  ±0   3m 56s ⏱️ +24s
 54 tests ±0   53 ✅ ±0  1 💤 ±0  0 ❌ ±0 
223 runs  ±0  220 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit b20f10c. ± Comparison against base commit 31cb885.

Copy link
Collaborator

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we merge this?

@nikrooz
Copy link
Contributor Author

nikrooz commented Aug 14, 2025

I was holding off on deprecating them until the documentation was updated, but if that’s not required, we can merge.

@nikrooz nikrooz marked this pull request as ready for review August 14, 2025 13:20
@slinkydeveloper slinkydeveloper merged commit 7bf6c68 into main Sep 15, 2025
5 checks passed
@slinkydeveloper slinkydeveloper deleted the NN_deprecated branch September 15, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants