Using a different method to get the absolute path. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method in this change uses an InputStream instead of a File object. The use of a method that doesn't depends of a File object, makes possible a deploy into a WebLogic because with WebLogic the configuration files are loaded from a generated jar instead of a file in the filesystem.
+1 fix a problem when using SpringBoot and starting the application as an executable Jar.Original error without this fix was: Could you please review this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method in this change uses an InputStream instead of a File object.
The use of a method that doesn't depends of a File object, makes possible a deploy into a WebLogic because with WebLogic the configuration files are loaded from a generated jar instead of a file in the filesystem.
The motivation for this change is in this issue: #68
I've tested myself this change with a simple spring boot project, using «gradle bootRun», delploying into a Tomcat server and into a WebLogic server. The three cases worked as expected.