Skip to content

Conversation

rektide
Copy link
Contributor

@rektide rektide commented Sep 23, 2022

Pre-Submission Checklist

Issues

Summarize the issues that discussed these changes

Closes:

Changes

What does this PR do?

@rektide rektide changed the title Node 14+ required Maintained Node.js (14+) required Sep 23, 2022
@rektide rektide changed the title Maintained Node.js (14+) required chore: maintained Node.js (14+) required Oct 3, 2022
| 16.x | **Yes** | Active LTS |
| 14.x | **Yes** | Maintenance LTS |
| 12.x | **No** | Use restify v8.x, team will backport critical issues only |
| 12.x | **No** | Use restify v8.x, team will backport critical issues only |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate line? unless you meant to say 10.x?

| 16.x | **Yes** | Active LTS |
| 14.x | **Yes** | Maintenance LTS |
| 12.x | **No** | Use restify v8.x, team will backport critical issues only |
| 12.x | **No** | Use restify v8.x, team will backport critical issues only |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| 12.x | **No** | Use restify v8.x, team will backport critical issues only |
| 10.x | **No** | Use restify v8.x, team will backport critical issues only |

@rektide rektide force-pushed the node-14 branch 2 times, most recently from 16b8fbd to 82ec9c8 Compare January 9, 2023 21:41
The MIT License (MIT)

Copyright (c) 2018 restify
Copyright (c) 2023 restify
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this change

"coveralls": "^3.0.3",
"documentation": "^11.0.0",
"eslint": "^5.16.0",
"eslint": "^6.8.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't make an unrelated change unless strictly necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated Node 10 & 12 support. Docs talk about node v11 as LTS - but current LTS is v16.

4 participants