This repository was archived by the owner on May 10, 2018. It is now read-only.
Defect. Disappear all carousel elements. #399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some mobile tablets, when we move to last page in portrait mode, which has one element and after that we change orientation to landscape, all elements just disappear (For example: Apple iPad 3, iOS 8.3) That happened, because some index, scope.carouselIndex do not have time to recalculate. I added 'debounce' pattern for 'orientationchange' event ( https://css-tricks.com/the-difference-between-throttling-and-debouncing/ )
|
For some mobile tablets, when we move to last page in portrait mode, which has one element and after that we change orientation to landscape, all elements just disappear (For example: Apple iPad 3, iOS 8.3) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some mobile tablets, when we move to last page in portrait mode, which has one element and after that we change orientation to landscape, all elements just disappear (For example: Apple iPad 3, iOS 8.3)
That happened, because some index, scope.carouselIndex do not have time to recalculate.
I added 'debounce' pattern for 'orientationchange' event
( https://css-tricks.com/the-difference-between-throttling-and-debouncing/ )