This repository was archived by the owner on May 10, 2018. It is now read-only.
feat(rn-carousel-indicators): prevent click event from bubbling up #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user clicked on the indicators, the event bubbled upwards. If for example a click handler watches for clicks on the image to show it in fullscreen, this leads to problems. Now this is prevented by using `event.stopPropagation`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user clicked on the indicators, the event bubbled upwards. If for example a click handler watches for clicks on the image to show it in fullscreen, this leads to problems. Now this is prevented by using
event.stopPropagation.