Skip to content

fix: syntax mismatch in git diff #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: syntax mismatch in git diff #97

wants to merge 1 commit into from

Conversation

@rockyzhang24
Copy link
Contributor

Closes #96

Solution:

  1. Check /dev/null in the pattern of diffOldFile and diffNewFile
  2. Define a region of git hunk and make the matching of removed and added lines take effect only inside the region.
  3. Deal with margin is 0 and 1 respectively.

@rockyzhang24 rockyzhang24 force-pushed the fix-syntax-mismatch branch from e7fd13a to d52b554 Compare May 18, 2025 18:55
rhysd
rhysd requested changes May 30, 2025
View reviewed changes
@rockyzhang24 rockyzhang24 force-pushed the fix-syntax-mismatch branch from d52b554 to 6efa5c1 Compare May 30, 2025 17:37
@rockyzhang24
Copy link
Contributor Author

@rhysd Thank you for your review. I already made a amend commit to address problems. Please check.

@rockyzhang24 rockyzhang24 requested a review from rhysd October 6, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhysd rhysd Awaiting requested review from rhysd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Syntax mismatch

2 participants

@rockyzhang24 @rhysd