Enable processing of many images #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the delay - looks like a useful set of changes. Will try to review over the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of thanks for this awesome module :)
However i ran into two minor problems, in case u want to export a lot of images to a sprite ( a couple of hundreds).
The first issue is that node will throw an error because too many files are open. This can be fixed by using 'graceful-fs'
The other issue is that it takes a lot of time to render all the differences onto the final spritesheet, this can be fixed by using imagemagicks 'convert' with the composite option instead of the composite tool itself. Convert is able to handle bulks of images at once which speeds up the process alot.
Hope the changes make sense.