[fix] a nicer error handling instead of app crash #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the app won't crash in case the string path represents an invalid URL (probably due to spaces in path), instead it will return a Flutter error from the plugin.
|
This PR fixes this issue: |
ibedek
pushed a commit
to ibedek/flutter_audio_recorder
that referenced
this pull request
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Change
Tip 💡
Try not to use force unwrap
!unless you want the app to crash. For example, inlet dic = call.arguments as! [String : Any]it's still forgiven because this dictionary must exist, unless there's an integration error. Although I personally prefer to use safe unwrap (if let/guard let) in these cases as well.