Skip to content

Conversation

Anxhela21
Copy link

Description

In LCORE evaluation we are temporarily depending on road-core dependencies. The road-core service has hard requirement for torch version 2.7.0+cpu which is incompatible for mac (requires 2.6.0). In this PR we remove torch from main dependencies and instead define platform-specific versions under optional dependency group

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in order for tests to pass on CI, the lockfile should be generated for "default", "dev", and also probably "evaluation" groups (and now for "torch-linux"). It might fix CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants