Small fixups found building with bazel #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjreiniger
force-pushed
the
bazel_cleanups
branch
from
6a9a68f to
f9139a6
Compare
pjreiniger
commented
Aug 20, 2025
pjreiniger
force-pushed
the
bazel_cleanups
branch
from
f9139a6 to
35e353d
Compare
auscompgeek
approved these changes
Aug 21, 2025
| ^ (std::hash<double>{}(self->blue) << 2) | ||
| ); | ||
| return h != -1 ? h : -2; | ||
| return h != static_cast<size_t>(-1) ? h : -2; |
There was a problem hiding this comment.
My bad. Now I wonder if pybind11 handles this pitfall for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update-initsectionDifferentialDriveFeedforward.ymlhad no package set. It was the only file in thecontrolspackage without itwpimath_testis not in the subproject list, so the./rdev.sh update-yamldoes not run on it. I only ran the tool, I don't think it needs to be treated as a subproject, but I'll leave that up to you.wpimath_testdid not explicitly define a dependency onwpimath. It was just always installed by the time it was built here.allwpilibbuilds with warnings as errors. While I do suppress some extra ones, the only time acomparing a signed and unsigned valuewould happen is in manually written code, which is what happens inColor.yml. Doing this explicit cast should behave identically.Note I found these on 2027 and backported it to main