wpimath: Remove floorDiv and floorMod #200
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions provide identical results to the native Python operators
//
and%
. I've verified this is true by property testing with hypothesis.These functions are objectively worse than the native operators in two ways:
operator
module, and the native operators consistently win out from a random sample -- pytest-codspeed consistently runs almost 2x iterations of the native operators with less total runtime.* Framework Laptop 13, AMD Ryzen 5 7640U, Fedora Linux 42, Python 3.12.11, kernel 6.16.7-200.fc42.x86_64