-
Notifications
You must be signed in to change notification settings - Fork 211
Implement React 19 TypeScript example #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import React, { Component, ReactNode } from 'react'; | ||
import Rollbar from 'rollbar'; | ||
|
||
interface Props { | ||
children: ReactNode; | ||
rollbar: Rollbar; | ||
} | ||
|
||
interface State { | ||
hasError: boolean; | ||
} | ||
|
||
class ErrorBoundary extends Component<Props, State> { | ||
constructor(props: Props) { | ||
super(props); | ||
this.state = { hasError: false }; | ||
} | ||
|
||
static getDerivedStateFromError(error: Error): State { | ||
// Update state so the next render will show the fallback UI. | ||
return { hasError: true }; | ||
} | ||
|
||
componentDidCatch(error: Error, info: React.ErrorInfo) { | ||
this.props.rollbar.info(error.message); | ||
} | ||
|
||
render() { | ||
if (this.state.hasError) { | ||
// You can render any custom fallback UI | ||
return <h1>Something went wrong.</h1>; | ||
} | ||
|
||
return this.props.children; | ||
} | ||
} | ||
|
||
export default ErrorBoundary; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import React, { Component } from 'react'; | ||
|
||
interface State { | ||
throwError: boolean; | ||
} | ||
|
||
class TestError extends Component<{}, State> { | ||
constructor(props: {}) { | ||
super(props); | ||
|
||
this.state = { throwError: false }; | ||
|
||
this.setErrorState = this.setErrorState.bind(this); | ||
} | ||
|
||
setErrorState() { | ||
// Use an error state and throw inside render, | ||
// because React won't send errors within event handlers | ||
// to the error boundary component. | ||
this.setState({ throwError: true }); | ||
} | ||
|
||
render() { | ||
if (this.state.throwError) { | ||
throw new Error('react child test error'); | ||
} | ||
return ( | ||
<React.Fragment> | ||
<h1>Rollbar Example for React Child Component</h1> | ||
<button id="child-error" onClick={this.setErrorState}> | ||
Throw Child Error | ||
</button> | ||
</React.Fragment> | ||
); | ||
} | ||
} | ||
|
||
export default TestError; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React now has a short syntax for
React.Fragment
. 🎉https://legacy.reactjs.org/docs/fragments.html#short-syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied https://github.com/rollbar/rollbar.js/blob/master/examples/react/src/index.js#L36-L48 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, I got it. I'll change them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't know if they had that yet in 2019.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The long form is still perfectly valid.