Skip to content

Conversation

guitargeek
Copy link
Contributor

This way, we are not affected by problems downloading the connection check file from root.cern.

@guitargeek guitargeek self-assigned this Aug 13, 2025
@guitargeek guitargeek requested a review from dpiparo as a code owner August 13, 2025 13:15
@guitargeek guitargeek added clean build Ask CI to do non-incremental build on PR in:CI labels Aug 13, 2025
@guitargeek guitargeek changed the title [ci] Set check_connection=ON globally [ci] Set check_connection=OFF globally Aug 13, 2025
This way, we are not affected by problems downloading the connection
check file from `root.cern`.
@andresailer
Copy link
Contributor

Some tests are going to fail downloading files from root.cern if that server has issues.

@guitargeek
Copy link
Contributor Author

That's true, but at least it will actually build and run the tests 🙂

Thanks for having tried and fixed this flag, by the way!

Copy link

Test Results

    21 files      21 suites   3d 10h 52m 48s ⏱️
 3 360 tests  3 360 ✅ 0 💤 0 ❌
68 840 runs  68 840 ✅ 0 💤 0 ❌

Results for commit f7c9363.

@dpiparo
Copy link
Member

dpiparo commented Aug 18, 2025

thanks for this upgrade. Could this be documented in the 6.38 flags here https://root.cern/install/build_from_source/#all-build-options ?

@guitargeek
Copy link
Contributor Author

Sure! root-project/web#1143

@guitargeek guitargeek merged commit cbd0819 into root-project:master Aug 19, 2025
26 checks passed
@guitargeek guitargeek deleted the check_connection branch August 19, 2025 11:56
@pcanal
Copy link
Member

pcanal commented Aug 19, 2025

Set check_connection=OFF globally

Do we still test check_connection=ON somewhere?

@guitargeek
Copy link
Contributor Author

guitargeek commented Aug 19, 2025

No. But you're right, we should do it at least on one platform. I'll change that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean build Ask CI to do non-incremental build on PR in:CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants