[net] Add libcurl based support for files on HTTP remotes #19842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jblomer I'll check |
RCurlConnection is an internal class that wraps around a libcurl easy handle. The RCurlConnection class takes care of - URL escaping - HEAD request - (Multi-)Range GET requests
Enable on all platforms except - mac13: libcurl is built without the 'threadsafe' option, hence disabling it there. Newer versions of macOS have that feature enabled. - Ubuntu 22: libcurl version too old (7.81 vs. 7.84)
Test Results 8 files 8 suites 1d 14h 22m 36s ⏱️ Results for commit 11c23f0. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
TFileandRRawFileplugins that use libcurl for the HTTP transfers. This can eventually replace the Davix dependency and also the olderTWebFileandTS3WebFile. The curl library gives access to a modern HTTP implementation (e.g., h2), and it works on Linux, macOS, and Windows with their respective native SSL stacks.@bellenot: on Windows, we may need to build libcurl ourselves. As far as I understand, Windows ships the
curlcommand line library but not the library.The current implementation does HEAD and (multi-)range GET queries, which provides the basics for efficient use of HTTP in ROOT. It can be enabled with
-Dcurl=on. If davix is available alongside the curl plugins, the curl plugins replace the davix plugins ifCurl.ReplaceDavix: yesis set in the rootrc file.Authentication can relatively easily be added, since S3 (AWSv4 signatures), bearer token authentication and X.509 client certificates are already supported by libcurl.
Metalink support can in principle be added if still needed. It requires XML parsing of the metalink snippet.
Write support (POST, PUT) requests can in principle be added if still needed, but require a closer look.
See also root-project/root-ci-images#73