[ntuple] Fix automatic schema evolution of record fields #19846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblomer
changed the title
jblomer
force-pushed
the
ntuple-fix-record-evolution
branch
from
606a7d8 to
1217e71
Compare
Test Results 21 files 21 suites 3d 13h 55m 28s ⏱️ For more details on these failures, see this check. Results for commit 42e5bbc. ♻️ This comment has been updated with latest results. |
hahnjo
approved these changes
Sep 15, 2025
silverweed
reviewed
Sep 15, 2025
silverweed
reviewed
Sep 15, 2025
jblomer
force-pushed
the
ntuple-fix-record-evolution
branch
from
1217e71 to
7590380
Compare
jblomer
force-pushed
the
ntuple-fix-record-evolution
branch
from
7590380 to
67a9de2
Compare
For std::pair and std::tuple, check that the number of subfields in memory and on disk is identical. For 2 subfields, std::pair and std::tuple are interchangible. The pair/tuple elements don't need to be an exact match but are themselves subject to automatic schema evolution.
The privileged access of RClassField to RFieldBase is used to modify some properties of its subfields. Make this more targeted through protected methods. One of the methods, CallSetArtificialOn(), will be reused by the record field.
Ensure that record field evolution supports missing fields, reordered fields, and added fields. Mark added fields as artificial (which was missing before).
Prevent pair and tuple fields from being demoted to record fields by adding their own CloneImpl() overrides.
Record fields are used for 1) untyped records 2) emulated classes and as 3) base class for the pair and tuple fields. These three cases use different constructors and have different reconciliation logic wrt. to the on-disk information. Make this more clear through code comments. Shortcut reconciliation for emulated fields.
jblomer
force-pushed
the
ntuple-fix-record-evolution
branch
from
67a9de2 to
42e5bbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes automatic schema evolution for
std::pairandstd::tuple, which are implemented as descendants of theRRecordField.Fixes #19254