Skip to content

Conversation

magnustymoteus
Copy link
Contributor

@magnustymoteus magnustymoteus commented Sep 10, 2025

This Pull request:

Changes or fixes:

  • Add the icon for RNTuple-visualization node in config/mimes.unix.in and config/mimes.win32.in
  • Visualization node represented by RVisualizationBrowsable class, which visualizes the corresponding ntuple on click as a treemap
  • Use RTreeMap classes from included ROOTTreeMap module for treemap visualization
  • Adapting the ntuple_browse test to the changes

node
viz

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@magnustymoteus magnustymoteus changed the title [ntuplebrowse] Add treemap visualization in classic ntuplebrowser for ntuples [ntuplebrowse] Add treemap visualization in classic ntuplebrowser Sep 10, 2025
@silverweed silverweed self-assigned this Sep 10, 2025
@magnustymoteus
Copy link
Contributor Author

It seems like there is a single test failing from the changes, let me check into that

@magnustymoteus
Copy link
Contributor Author

magnustymoteus commented Sep 10, 2025

The test assumed that the first child of rntuple node in the browser was a field, which would now be the visualization node. I changed the test to reflect my changes and now it should pass.

Copy link

Test Results

    20 files      20 suites   3d 13h 47m 15s ⏱️
 3 663 tests  3 651 ✅   0 💤 12 ❌
71 547 runs  71 346 ✅ 189 💤 12 ❌

For more details on these failures, see this check.

Results for commit b3d6b06.

@silverweed silverweed merged commit 5ba79a9 into root-project:master Sep 15, 2025
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants