[RF] Add base-case overload for RooAbsReal::matchArgs implementation
#19869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In user frameworks based on RooFit, there were linker errors with ROOT `master`: ```txt undefined reference to RooAbsReal::matchArgs(RooArgSet const&, RooArgSet&, RooArgProxy const&) const ``` This can be fixed by treating the case of no extra arguments to the variadic `matchArgs` function as a separate overload, so it get consistently not inlined. Thanks @cburgard for noticing and reporting! Follows up on 85186f3, which implemented `RooAbsReal::matchArgs` with variadic templates.
Test Results 20 files 20 suites 3d 16h 47m 6s ⏱️ Results for commit a64aa8ac. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In user frameworks based on RooFit, there were linker errors with ROOT
master:This can be fixed by treating the case of no extra arguments to the variadic
matchArgsfunction as a separate overload, so it get consistently not inlined.Thanks @cburgard for noticing and reporting!
Follows up on 85186f3, which implemented
RooAbsReal::matchArgswith variadic templates.