[ntuple] cache number of entries in reader #19877
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcanal
reviewed
Sep 12, 2025
| ROOT::NTupleSize_t ROOT::RNTupleReader::GetNEntries() const | ||
| { | ||
| if (fCachedNEntries == ROOT::kInvalidNTupleIndex) | ||
| fCachedNEntries = fSource->GetNEntries(); |
There was a problem hiding this comment.
Is there any way fSource could be a nullptr? Either way, could the fCachedNEntries be set as soon as fSource is set?
Test Results 20 files 20 suites 3d 12h 21m 23s ⏱️ For more details on these failures, see this check. Results for commit 4d5df2e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #19763