Skip to content

[core] improve by two the ttimer resolution #20307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[core] improve by two the ttimer resolution #20307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/base/inc/Rtypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ enum ESysConstants {
kMAXSIGNALS = 16,
kMAXPATHLEN = 8192,
kBUFFERSIZE = 8192,
kItimerResolution = 10 // interval-timer resolution in ms
kItimerResolution = 5 ///< interval-timer resolution in ms (used for TThread, TTimer, Emit, Connect, etc.)
};

enum EColor { kWhite =0, kBlack =1, kGray =920,
Expand Down
2 changes: 1 addition & 1 deletion core/base/inc/TTimer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
// Timeout() signal and call connected slots. //
// //
// Minimum timeout interval is defined in TSystem::ESysConstants as //
// kItimerResolution (currently 10 ms). //
// kItimerResolution (currently 5 ms). //
// //
// Signal/slots example: //
// TTimer *timer = new TTimer(); //
Expand Down
8 changes: 4 additions & 4 deletions core/base/src/TTimer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ You can use this class in one of the following ways:
appropriate methods. Then when the time is up it will emit a
Timeout() signal and call connected slots.

Minimum timeout interval is defined in TSystem::ESysConstants as
`kItimerResolution` (currently 10 ms).
Minimum timeout interval is defined in Rtypes.h ESysConstants as
`kItimerResolution` (currently 5 ms).

Signal/slots example:
~~~{.cpp}
Expand All @@ -54,7 +54,7 @@ class TSingleShotCleaner : public TTimer {
private:
TList *fGarbage;
public:
TSingleShotCleaner() : TTimer(10, kTRUE) { fGarbage = new TList(); }
TSingleShotCleaner() : TTimer(5, kTRUE) { fGarbage = new TList(); }
~TSingleShotCleaner() override
{
fGarbage->Delete();
Expand All @@ -81,7 +81,7 @@ class TSingleShotCleaner : public TTimer {
////////////////////////////////////////////////////////////////////////////////
/// Create timer that times out in ms milliseconds. If milliSec is 0
/// then the timeout will be the minimum timeout (see TSystem::ESysConstants,
/// i.e. 10 ms). If mode == kTRUE then the timer is synchronous else
/// i.e. 5 ms). If mode == kTRUE then the timer is synchronous else
/// a-synchronous. The default is synchronous. Add a timer to the system
/// eventloop by calling TurnOn(). Set command to be executed from Notify()
/// or set the object whose HandleTimer() method will be called via Notify(),
Expand Down
4 changes: 2 additions & 2 deletions core/thread/inc/TThread.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,10 +202,10 @@ class TThreadCleaner {

class TThreadTimer : public TTimer {
public:
// if this time is less or equal to kItimerResolution, TUnixSystem::DispatchOneEvent i
// if this time is less or equal to kItimerResolution, TUnixSystem::DispatchOneEvent
// can not exit and have its caller react to the other TTimer's actions (like the request
// to stop the event loop) until there is another type of event.
TThreadTimer(Long_t ms = kItimerResolution + 10);
TThreadTimer(Long_t ms = kItimerResolution + 5);
Bool_t Notify() override;
};

Expand Down
Loading