[roottest] Improve io/newstl tests, add reference ROOT files #20319
+149
−285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 22h 17m 15s ⏱️ Results for commit aeb53b7. ♻️ This comment has been updated with latest results. |
Older version of the test tried to list current directory for files created by previous version of tests. Now such situation is not possible, therefore remove such listing
One can add reference files to check that reading remains working also for older files. So add for beginiing reference files from 6-32-19 version. Some older files can be add as well
linev
force-pushed
the
roottest_newstl_read
branch
from
dc86007 to
354a281
Compare
variable size array of stl containers is not implemented so it appears in test output every time - and differs on different platforms. Just comment out it to avoid variation of tests output.
Member
|
@dpiparo This is an interesting option to preserve the legacy root files (i.e. store them in the repository). The other option would be to store them (and retrieve them for the purpose of this test) in EOS. For perspective, a clean complete clone of the ROOT source is 2.2GB, while each set of files is approximately 1.6MB. |
Member
|
How much would we add in total in terms of size if we added the files to the repo? |
Member
Author
|
I do not think that we need to add many different ROOT versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Makefile-based testing newstl tests were writing ROOT files into sub-directory with current version id.
So if same roottest was running with different ROOT version - it was creating different sub-dirs with such files.
And roottest was trying to read all these directories afterwards.
This functionality was never in use for CI - while never same roottest was running with different ROOT versions.
Now directly add ROOT files from previous ROOT versions and test reading of such files.
While automatic directory listing no longer required - simplify tests in this respect.
For the beginning add files generated with ROOT 6-32-19.
Fixes: #20313