[ntuple] Create streamer info records from TClass normalized name #20322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the templated version of the RClassField, the type name passed to TClass::GetClass() must not use the RNTuple normalized name but the demangled name or the meta normalized name. Otherwise, RNTuple may normalize, e.g., `long long` to `std::int64_t`, which in turn gets normalized by Meta to `unsigned long`.
jblomer
force-pushed
the
ntuple-fix-streamer-info
branch
from
e93e580 to
4be5f02
Compare
jblomer
force-pushed
the
ntuple-fix-streamer-info
branch
from
4be5f02 to
86ffa2a
Compare
hahnjo
reviewed
Nov 7, 2025
Test Results 21 files 21 suites 3d 15h 18m 42s ⏱️ Results for commit 1f6a481. ♻️ This comment has been updated with latest results. |
Get the streamer info records of class fields and streamer fields from their meta (TClass) normalized name. Previously, the names came from the descriptor, which has them already RNTuple normalized.
jblomer
force-pushed
the
ntuple-fix-streamer-info
branch
from
86ffa2a to
1f6a481
Compare
hahnjo
approved these changes
Nov 10, 2025
Member
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
LGTM; still an open question for IsCustomClass, but feel free to keep the function for now and resolve the thread
|
Thanks! Could we have this PR backported to 6.36? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20282