[IO] Fix rootcp --replace flag not working with recursive copy

[ahmedbilal9]

Fixes #7052

Changes or fixes:

The --replace flag was not being checked when copying regular objects (non-tree, non-collection) in recursive mode. This caused objects to be written with new cycles instead of replacing existing ones.

Added replaceOption check in the else block of copyRootObjectRecursive() to delete existing objects before writing replacements.

Checklist:

• Tested changes locally
• Updated the docs (if necessary)

[guitargeek]

Thank you very much for your PR! Could you fix the Python syntax errors? Thanks.

[ahmedbilal9]

The CI failures appear to be unrelated to my changes. The build is failing with:

Error: roofit/hs3/src/RooJSONFactoryWSTool.cxx:260:1: error: '{anonymous}::Var::Var' defined but not used [-Werror=unused-function]

This error is in C++ RooFit code, while my changes only modify main/python/cmdLineUtils.py. The Python linting checks (ruff) pass successfully.

Could a maintainer please advise if this is a known issue or if I should rebase on the latest master?

[github-actions]

Test Results

    19 files      19 suites   3d 13h 19m 41s ⏱️
 3 741 tests  3 737 ✅   1 💤  3 ❌
69 365 runs  69 058 ✅ 287 💤 20 ❌

For more details on these failures, see this check.

Results for commit 86a3691.

[ahmedbilal9]

Hi @bellenot,

I've fixed the Python linting errors as requested. The ruff check now passes successfully .

However, the CI is failing with an error in RooFit code that appears unrelated to my changes:
Error: roofit/hs3/src/RooJSONFactoryWSTool.cxx:260:1: error: '{anonymous}::Var::Var' defined but not used
My PR only modifies main/python/cmdLineUtils.py, while this failure is in C++ RooFit code.

Could you advise if:

1. This is a known issue in the current master branch?
2. Should I rebase my branch on the latest master?
3. Or should we wait for the RooFit issue to be resolved?

Thank you for your guidance!

[bellenot]

Hi @ahmedbilal9 I see failures like:

1795:roottest-main-SimpleRootmv1
1796:roottest-main-SimpleRootmv1CheckOutput
1797:roottest-main-SimpleRootmv1Clean

And not the one with RooFit

[ahmedbilal9]

Hi @ahmedbilal9 I see failures like:

1795:roottest-main-SimpleRootmv1
1796:roottest-main-SimpleRootmv1CheckOutput
1797:roottest-main-SimpleRootmv1Clean

And not the one with RooFit

Hi @bellenot,

Thank you for clarifying! I see now - the failures are in the roottest-main-SimpleRootmv tests, not the RooFit code.

I'll investigate these test failures:

• roottest-main-SimpleRootmv1
• roottest-main-SimpleRootmv1CheckOutput
• roottest-main-SimpleRootmv1Clean

Could you point me to where I can find the detailed CI logs for these tests, or should I look at the full CI output? I want to understand what specific behavior is failing so I can fix it properly.

Thank you!

[bellenot]

@ahmedbilal9 see https://github.com/root-project/root/runs/54877340609