Skip to content

Conversation

@vepadulano
Copy link
Member

Attempt at fixing failures such as seen on MacOS beta:

  Error in <CloseStreamerInfoROOTFile>: Unique pointer unique_ptr<PolyBase,default_delete<PolyBase> > has zero data members.

See e.g. https://github.com/root-project/root/actions/runs/19197912794/job/54881579525?pr=20353#step:6:5580

Attempt at fixing failures such as seen on MacOS beta:

```
  Error in <CloseStreamerInfoROOTFile>: Unique pointer unique_ptr<PolyBase,default_delete<PolyBase> > has zero data members.
```
@vepadulano vepadulano self-assigned this Nov 8, 2025
@vepadulano vepadulano marked this pull request as ready for review November 8, 2025 23:19
@vepadulano vepadulano requested a review from jblomer as a code owner November 8, 2025 23:19
@github-actions
Copy link

github-actions bot commented Nov 8, 2025

Test Results

    22 files      22 suites   3d 14h 9m 24s ⏱️
 3 738 tests  3 738 ✅ 0 💤 0 ❌
80 303 runs  80 303 ✅ 0 💤 0 ❌

Results for commit f9768ef.

vepadulano added a commit to vepadulano/root that referenced this pull request Nov 10, 2025
vepadulano added a commit to vepadulano/root that referenced this pull request Nov 10, 2025
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let put this band-aid on for now, so the other PR are not distracted, but we need to resolved/understand this.

@vepadulano vepadulano merged commit 941f519 into root-project:master Nov 11, 2025
29 checks passed
@hahnjo
Copy link
Member

hahnjo commented Nov 11, 2025

Unfortunately this didn't work, the build in master still fails with the same error: https://github.com/root-project/root/actions/runs/19250798263/job/55035175377 The reason is that this PR landed on macphsft34 which has

sftnight@macphsft34 ~ % sw_vers 
ProductName:		macOS
ProductVersion:		26.1
BuildVersion:		25B77
sftnight@macphsft34 ~ % clang --version
Apple clang version 17.0.0 (clang-1700.4.4.1)
Target: arm64-apple-darwin25.1.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

compared to

sftnight@macphsft35 ~ % sw_vers 
ProductName:		macOS
ProductVersion:		26.2
BuildVersion:		25C5031i
sftnight@macphsft35 ~ % clang --version
Apple clang version 17.0.0 (clang-1700.6.3.2)
Target: arm64-apple-darwin25.2.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

(btw the "correct" tag for commit messages is [ntuple])

@vepadulano
Copy link
Member Author

I was mislead as well because today's nightly actually run well https://github.com/root-project/root/actions/runs/19251983040/job/55038655542

This can be reverted then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants