Fix rootssh connection issues on MacOS [skip-ci] #20361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes connection issues on MacOS.
70rc
changed the title
linev
requested changes
Nov 10, 2025
Member
linev
left a comment
linev
left a comment
There was a problem hiding this comment.
Probably it make sense.
I change this line in May 2025, but didn't test on mac.
But change is not sufficient - in line 59 chmod -f 0700 $listener_socket fails for me too. So one need to adjust code here as well.
At the best one should check in the loop:
if [-f $listener_socket.log]; then
chmod -f 0700 $listener_socket
fi
@70rc, will you add such change?
Prevent failure on Mac where operation with non-existing files/sockets leads to failure
linev
changed the title
linev
approved these changes
Nov 11, 2025
Member
linev
left a comment
linev
left a comment
There was a problem hiding this comment.
I add extra commit to check socket before changing mode for it.
Thanks to reporting the problem!
Contributor
Author
|
@linev Apologies for the slow reaction, I'm in the middle of a beamtime. Thanks for adding the missing check yourself! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Fixes root connection issues on MacOS.
Changes or fixes:
Changed rootssh not to create the $listener_socket prior to calling nc.
nc BSD, which is used on MacOS, cannot connect to existing Unix sockets.
Checklist:
This PR
Fixes rootssh connection issues on MacOS.