Skip to content

Add test for ROOT_LIBRARY_PATH #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add test for ROOT_LIBRARY_PATH #686

wants to merge 1 commit into from

Conversation

pcanal
Copy link
Member

@pcanal pcanal commented Apr 7, 2021

No description provided.

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@pcanal pcanal self-assigned this Apr 7, 2021
@pcanal
Copy link
Member Author

pcanal commented Apr 7, 2021

@ChristianTackeGSI

@pcanal
Copy link
Member Author

pcanal commented Apr 7, 2021

@ChristianTackeGSI Could you take a look at the results?

@phsft-bot
Copy link

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@ChristianTackeGSI
Copy link

Hi @pcanal !

Thanks for taking care of this!

Obviously, my test should have had more output, so that one knows, where it fails. Hmpf.

But after starring a while at it, I have some vague idea:
/home/sftnight/build/workspace/roottest-pullrequests-build/build/lib is listed more than once in there, which already is suspicous.
So I wonder, whether LD_LIBRARY_PATH (or alike) has this path in it when the tests start?

Axel-Naumann
Axel-Naumann reviewed Jun 18, 2021
View reviewed changes
Copy link
Member

@Axel-Naumann Axel-Naumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a test using CMake's env command, which allows us to test this both on Windows and Linux/MacOS. Even if it's at the cost of having multiple subdirectories with their dedicated .rootrc.

Using a shall script means we will have to duplicate the whole setup for Windows, and makes debugging / reproducing / understanding the test more involved.

@ChristianTackeGSI
Copy link

@Axel-Naumann

First excuse me for not taking more care of this. It was always on my TODO-list, but not at the top.

So what you're suggesting is to rewrite the shell script into a .cmake script that could be executed like ROOTTEST_ADD_TEST(… COMMAND cmake ... -P ${CMAKE_CURRENT_SOURCE_DIR}/test_dynpath_setup.cmake -DROOT_root_CMD=${ROOT_root_CMD}?
And in the .cmake we use $ENV{…}?

Interesting approach! This might work, yes!
Would take me a bit of time to rewrite. But yes, I could look into this.

@pcanal pcanal force-pushed the ROOT_LIBRARY_PATH branch from c79a4aa to 24cfc9a Compare February 3, 2022 21:06
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

And 9 more

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build
See console output.

Errors:

  • [2022-02-04T12:02:03.824Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:1784 (message):
  • [2022-02-04T12:02:03.824Z] CMake Error at /data/sftnight/workspace/roottest-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Axel-Naumann Axel-Naumann Axel-Naumann left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@pcanal pcanal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcanal @phsft-bot @ChristianTackeGSI @Axel-Naumann