Update heltec_unofficial.h #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom PIN value for PROG button
|
I agree this is a nice thing to be able to do. The proper way is probably to make it more generic, also applying it to the other pins, but this doesn't hurt to have in there until then. |
|
Could you please merge? It will add support for the E290 and T170 boards.
The only difference is that you will need to disable display and use your
own library.
…On Tue, Sep 10, 2024 at 3:45 AM Rop Gonggrijp ***@***.***> wrote:
I agree this is a nice thing to be able to do. The proper way is probably
to make it more generic, also applying it to the other pins, but this
doesn't hurt to have in there until then.
—
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACGJNZQ6AQ2TK4MH5EYVKWLZV3EVXAVCNFSM6AAAAABN5J2H3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBQGMYTKNBVG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom PIN value for PROG button.
Boards T190, E230 have different PIN numbers - 21
It would be nice to make it redefinable.