Skip to content

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Sep 16, 2025

In a recent PMC meeting we decided to deprecate the specializations for the sake of reducing duplicate code here in the repository.

Should we rename the package (can be done by adding a shim package with the old name and deprecation warnings) before adding another controller (twist_controller from #300)?

Slightly related to #157 (no need for controller specifications if we use standard Float64MultiArray message anyways)

Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.26%. Comparing base (7b7ecb7) to head (d3e7bb6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1913   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files         143      143           
  Lines       13793    13793           
  Branches     1196     1196           
=======================================
  Hits        11760    11760           
  Misses       1636     1636           
  Partials      397      397           
Flag Coverage Δ
unittests 85.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._controllers/src/joint_group_effort_controller.cpp 62.50% <ø> (ø)
...ontrollers/src/joint_group_position_controller.cpp 66.66% <ø> (ø)
...ontrollers/src/joint_group_velocity_controller.cpp 62.50% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich added the check-prerelease-downstream Runs the pre-release workflow with 1st level downstream dependencies label Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check-prerelease-downstream Runs the pre-release workflow with 1st level downstream dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant