-
Notifications
You must be signed in to change notification settings - Fork 158
Expose StringJoinSubstitution to frontend #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rolling
Are you sure you want to change the base?
Expose StringJoinSubstitution to frontend #857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than some minor comments, this looks good.
Would you mind adding tests for frontends, i.e., YAML and XML? See the tests I added to launch_xml
and launch_yaml
in #802. Also, it would be good to add XML and YAML examples to the Python class docstring.
bc7bb1e
to
669c430
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests!
Other than some minor suggestions, this looks great!
…ent) Signed-off-by: Christian Ruf <[email protected]>
Signed-off-by: Christian Ruf <[email protected]>
Signed-off-by: Christian Ruf <[email protected]>
Signed-off-by: Christian Ruf <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Christian Ruf <[email protected]>
Signed-off-by: Christian Ruf <[email protected]>
Signed-off-by: Christian Ruf <[email protected]>
Signed-off-by: Christian Ruf <[email protected]>
Signed-off-by: Christian Ruf <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Christian Ruf <[email protected]>
…ent) Signed-off-by: Christian Ruf <[email protected]>
207ac0c
to
425d0f2
Compare
Signed-off-by: Christian Ruf <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Christian Ruf <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Christian Ruf <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Christian Ruf <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Christian Ruf <[email protected]>
This PR exposes StringJoinSubstitution from #843 to the frontend, as suggested by @christophebedard in #843.
Usage
(i.e. with
delimiter=.
andstring components=[https://$(var subdomain), ros, org]
):results in terminal output