Skip to content

Conversation

baconbrot
Copy link
Contributor

This PR exposes StringJoinSubstitution from #843 to the frontend, as suggested by @christophebedard in #843.

Usage

(i.e. with delimiter=. and string components=[https://$(var subdomain), ros, org]):

%YAML 1.2
---
launch:
  - arg:
      name: subdomain
      default: 'wiki'
  - log:
      message: "$(string-join . https://$(var subdomain) ros org)"

results in terminal output

[INFO] [launch.user]: https://wiki.ros.org

@baconbrot baconbrot marked this pull request as draft April 12, 2025 12:32
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some minor comments, this looks good.

Would you mind adding tests for frontends, i.e., YAML and XML? See the tests I added to launch_xml and launch_yaml in #802. Also, it would be good to add XML and YAML examples to the Python class docstring.

@baconbrot baconbrot force-pushed the stringjoinsubstitution_frontend branch from bc7bb1e to 669c430 Compare April 27, 2025 18:12
@baconbrot baconbrot marked this pull request as ready for review April 27, 2025 18:30
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!

Other than some minor suggestions, this looks great!

baconbrot added a commit to baconbrot/launch that referenced this pull request Oct 21, 2025
@baconbrot baconbrot force-pushed the stringjoinsubstitution_frontend branch from 207ac0c to 425d0f2 Compare October 21, 2025 11:17
baconbrot and others added 4 commits October 22, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants