Skip to content

Primary state error transitions #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Primary state error transitions #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lifecycle_msgs/msg/Transition.msg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@ uint8 TRANSITION_ON_ERROR_SUCCESS = 60
uint8 TRANSITION_ON_ERROR_FAILURE = 61
uint8 TRANSITION_ON_ERROR_ERROR = 62

# These transitions are internally
# available to the lifecycle node to
# be called when an error arises during
# normal operation that causes the node
# to need reconfiguration.
uint8 TRANSITION_ACTIVE_ERROR = 63
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably not be sequential but pick a new decade starting with 70

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rcl_interfaces/lifecycle_msgs/msg/Transition.msg

Line 43 in 018fe20

# Reserved [10-69], private transitions

Reserved [10-69], private transitions

it needs to expand reserved range.

uint8 TRANSITION_INACTIVE_ERROR = 64

# These return values ought to be set
# as a return value for each callback.
# Depending on which return value,
Expand Down