-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Feat/rate limited teleop doc #5847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rolling
Are you sure you want to change the base?
Conversation
Signed-off-by: Garegin Mazmanyan <[email protected]>
Signed-off-by: Garegin Mazmanyan <[email protected]>
Thanks for taking a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps mention the RateLImiter from ros2_control?
…ontrol Signed-off-by: Garegin Mazmanyan <[email protected]>
Thanks for the pointer. I added a “See also” section referencing control_toolbox::RateLimiter and the control_filters::RateLimiter plugin for ros2_control (with links). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tothelast thanks for creating issue and PR.
although i think this is useful, i believe this feature can be implemented in teleop package as optional argument with documentation in that package? if this is the major problem when we use the teleop, that is gonna be much helpful for user instead of implementing this example into their workspace. IMO, once it is completed, we probably refer to the optional argument in the tutorial here.
what do you think about this?
besides that, i think Rate Control Subscription
can be the feature for any Subscription endpoints to avoid the situation that more messages are coming in than it can handle. but this is another discussion.
Agreed, adding an optional rate-limit flag in teleop_twist_keyboard makes this much easier for users. I can open an Issue + PR there to add a --rate-limit option (with linear/Angular accel params and default-off) and then update this tutorial to point to that flag as the primary path, keeping the standalone node as a fallback. If that approach sounds good, I can proceed and link the PR here. What do you think? @fujitatomoya |
Signed-off-by: Garegin Mazmanyan <[email protected]>
Fixes #5848
Add an Advanced tutorial: Smoothing keyboard teleop with a rate-limiter.
Included
source/Tutorials/Advanced/rate_limited_teleop.rst
source/Tutorials/Advanced.rst
Rationale
Keyboard teleop can produce abrupt 0→max command steps. A small Twist acceleration limiter improves smoothness and safety, especially in indoor labs and teaching settings.
Checks
Signed-off-by
present on all commitsUpdate: Addressed review feedback - added a “See also” section referencing
control_toolbox::RateLimiter
and thecontrol_filters::RateLimiter
plugin forros2_control
(with links).