Skip to content

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Feb 9, 2021

Built on top of #567. Connected to #565.

@hidmic hidmic mentioned this pull request Feb 9, 2021
21 tasks
@hidmic hidmic force-pushed the hidmic/rosidl-generate-cpp branch from 38ab3b4 to 2fbf5c3 Compare February 15, 2021 20:38
@hidmic hidmic force-pushed the hidmic/rosidl-generate-cpp branch 2 times, most recently from aa5174a to 203a544 Compare March 5, 2021 19:53
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as this other PR and fix the conflics

@hidmic hidmic force-pushed the hidmic/rosidl-generate-cpp branch from 203a544 to 9f58f46 Compare March 9, 2021 20:54
@hidmic hidmic requested a review from ahcorde March 9, 2021 20:56
<!-- This is needed for the rosidl_message_type_support_t struct and visibility macros -->
<build_export_depend>rosidl_generator_c</build_export_depend>

<exec_depend>rosidl_cli</exec_depend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include ament_index_python as a <exec_depend>

@hidmic
Copy link
Contributor Author

hidmic commented Mar 10, 2021

Running CI up to rosidl_generator_cpp:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic hidmic requested a review from ahcorde March 10, 2021 14:31
@hidmic hidmic merged commit 22c2cac into master Mar 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the hidmic/rosidl-generate-cpp branch March 10, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants