Fix std::fill templating #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carlstrom <[email protected]>
|
While continuing on #881 ran into a problem this happen to fix, while not needed it simplifies the fill logic. |
fujitatomoya
approved these changes
Aug 17, 2025
ahcorde
approved these changes
Aug 18, 2025
|
Pulls: #884
|
|
Can aarch and Windows be re-run? Linux and rhel I believe are normal failures. |
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
static_cast<unsigned char>to generate default and zero for filling of the correct type. In theory you could generate the exact char however, there is no simple python function for generating the conversion.Fixes #309
Is this user-facing behavior change?
Did you use Generative AI?
Additional Information