Skip to content

Add DEPENDS_EXPLICIT_ONLY to remove implicit dependencies #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
+21 −0
Open

Add DEPENDS_EXPLICIT_ONLY to remove implicit dependencies #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c25da9
Add DEPENDS_EXPLICIT_ONLY to remove implicit dependencies
TonyWelte Sep 30, 2025
ce8568e
Use version check instead of bumping minimum cmake version
TonyWelte Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...erator_type_description/cmake/rosidl_generator_type_description_generate_interfaces.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ rosidl_write_generator_arguments(
INCLUDE_PATHS "${_dependency_paths}"
)

if(${CMAKE_VERSION} VERSION_GREATER_EQUAL 3.27)
set(_dep_explicit_only DEPENDS_EXPLICIT_ONLY)
else()
set(_dep_explicit_only "")
endif()

# Create custom command and target to generate the hash output
add_custom_command(
COMMAND Python3::Interpreter
Expand All @@ -88,6 +94,7 @@ add_custom_command(
DEPENDS ${target_dependencies}
COMMENT "Generating type hashes for ROS interfaces"
VERBATIM
${_dep_explicit_only}
)

set(_target "${rosidl_generate_interfaces_TARGET}__rosidl_generator_type_description")
Expand Down
7 changes: 7 additions & 0 deletions ...upport_introspection_c/cmake/rosidl_typesupport_introspection_c_generate_interfaces.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@ set(Python3_FIND_UNVERSIONED_NAMES FIRST)

find_package(Python3 REQUIRED COMPONENTS Interpreter)

if(${CMAKE_VERSION} VERSION_GREATER_EQUAL 3.27)
set(_dep_explicit_only DEPENDS_EXPLICIT_ONLY)
else()
set(_dep_explicit_only "")
endif()

add_custom_command(
OUTPUT ${_generated_header_files} ${_generated_source_files}
COMMAND Python3::Interpreter
Expand All @@ -102,6 +108,7 @@ add_custom_command(
DEPENDS ${target_dependencies}
COMMENT "Generating C introspection for ROS interfaces"
VERBATIM
${_dep_explicit_only}
)

# generate header to switch between export and import for a specific package
Expand Down
7 changes: 7 additions & 0 deletions ...rt_introspection_cpp/cmake/rosidl_typesupport_introspection_cpp_generate_interfaces.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@ set(Python3_FIND_UNVERSIONED_NAMES FIRST)

find_package(Python3 REQUIRED COMPONENTS Interpreter)

if(${CMAKE_VERSION} VERSION_GREATER_EQUAL 3.27)
set(_dep_explicit_only DEPENDS_EXPLICIT_ONLY)
else()
set(_dep_explicit_only "")
endif()

add_custom_command(
OUTPUT ${_generated_header_files} ${_generated_source_files}
COMMAND Python3::Interpreter
Expand All @@ -102,6 +108,7 @@ add_custom_command(
DEPENDS ${target_dependencies}
COMMENT "Generating C++ introspection for ROS interfaces"
VERBATIM
${_dep_explicit_only}
)

set(_target_suffix "__rosidl_typesupport_introspection_cpp")
Expand Down