Skip to content

Support available typesupport specification in CLI extension #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Support available typesupport specification in CLI extension #133

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f45ea3
Support available typesupport specification in CLI extension
hidmic Jun 4, 2021
7183fda
Drop kwargs from CLI extension class
hidmic Jul 12, 2021
2157e4b
Keep CLI extension tests with no arguments
hidmic Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions rosidl_generator_py/rosidl_generator_py/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@

class GeneratePython(GenerateCommandExtension):

def __init__(self, name, *, typesupport_implementations=None, **kwargs):
super().__init__(name, **kwargs)
if typesupport_implementations is None:
typesupport_implementations = ['rosidl_typesupport_c']
typesupport_implementations.extend(
get_resources('rosidl_typesupport_c'))
self.__typesupport_implementations = typesupport_implementations

def generate(
self,
package_name,
Expand Down Expand Up @@ -55,10 +63,6 @@ def generate(
))

# Generate code
typesupport_implementations = ['rosidl_typesupport_c']
typesupport_implementations.extend(
get_resources('rosidl_typesupport_c')
)
with legacy_generator_arguments_file(
package_name=package_name,
interface_files=idl_interface_files,
Expand All @@ -68,4 +72,4 @@ def generate(
) as path_to_arguments_file:
return generate_py(
path_to_arguments_file,
typesupport_implementations)
self.__typesupport_implementations)
2 changes: 1 addition & 1 deletion rosidl_generator_py/test/test_cli_extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ def test_cli_extension_for_smoke(tmp_path):
generate(
package_name='rosidl_generator_py',
interface_files=[PACKAGE_DIR + ':msg/StringArrays.msg'],
types=['py'],
types=['py[typesupport_implementations:[rosidl_typesupport_c]]'],
output_path=tmp_path
)