Skip to content

ensure type safety of .indexOf(stamp); fixes #395 #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ensure type safety of .indexOf(stamp); fixes #395 #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions inst/htmlwidgets/leaflet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,7 +1097,7 @@ var LayerManager = function () {
if (layerInfo.ctGroup) {
var ctGroup = this._byCrosstalkGroup[layerInfo.ctGroup];
var layersForKey = ctGroup[layerInfo.ctKey];
var idx = layersForKey ? layersForKey.indexOf(stamp) : -1;
var idx = layersForKey ? layersForKey.indexOf(+stamp) : -1;
if (idx >= 0) {
if (layersForKey.length === 1) {
delete ctGroup[layerInfo.ctKey];
Expand Down Expand Up @@ -2348,7 +2348,6 @@ function _classCallCheck(instance, Constructor) { if (!(instance instanceof Cons
// pixel of the original image has some contribution to the downscaled image)
// as opposed to a single-step downscaling which will discard a lot of data
// (and with sparse images at small scales can give very surprising results).

var Mipmapper = function () {
function Mipmapper(img) {
_classCallCheck(this, Mipmapper);
Expand Down
2 changes: 1 addition & 1 deletion javascript/src/layer-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ export default class LayerManager {
if (layerInfo.ctGroup) {
let ctGroup = this._byCrosstalkGroup[layerInfo.ctGroup];
let layersForKey = ctGroup[layerInfo.ctKey];
let idx = layersForKey ? layersForKey.indexOf(stamp) : -1;
let idx = layersForKey ? layersForKey.indexOf(+stamp) : -1;
if (idx >= 0) {
if (layersForKey.length === 1) {
delete ctGroup[layerInfo.ctKey];
Expand Down