右と左でそれぞれ用意されている関数を一つにまとめる（リファクタリング） #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YusukeKato
added
the
Type: Refactoring
|
以下の環境でサンプルプログラムの動作確認ができました。コードの方もLGTMです。
|
KuraZuzu
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
リファクタリングの一環として、右と左でそれぞれ用意されている関数を一つにまとめます。
対象の関数
rtcntl_i2c_create_cdevとrtcntr_i2c_create_cdevset_motor_l_freqとset_motor_r_freqDoes this close any currently open issues?
しません。
How has this been tested?
下記の環境ですべてのサンプルプログラムが動作することを確認しました。
CIのビルドテストのチェックが通ることを確認しました。
Any other comments?
rawmotor_l_writeとrawmotor_r_writeはdev_fopsで使用するため、まとめていません。Checklists