Skip to content

Conversation

KuraZuzu
Copy link
Contributor

@KuraZuzu KuraZuzu commented Dec 9, 2024

What does this implement/fix?

エラーハンドリングをした際にmutex_unlock(&dev_info->lock);が呼ばれず、リソースリークを起こす可能性があるため、returnの前に追加します。

Does this close any currently open issues?

しません。

How has this been tested?

以下の環境で動作を確認しました。

  • Raspberry 4B (4GB)
    • Ubuntu 24.04 64bit 6.8.0-1014-raspi
    • Ubuntu 22.04 64bit 5.15.0-1063-raspi
    • RaspiOS 64bit 6.6.51+rpt-rpi-v8
    • RaspiOS 32bit 6.6.62+rpt-rpi-v7l

Any other comments?

Checklists

@KuraZuzu KuraZuzu added the Type: Bug Bug or Bug fixes label Dec 9, 2024
@KuraZuzu KuraZuzu requested a review from YusukeKato December 9, 2024 09:16
@KuraZuzu KuraZuzu self-assigned this Dec 9, 2024
Copy link
Contributor

@YusukeKato YusukeKato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raspberry Pi 4B + Ubuntu 24.04 LTSで動作確認できました。
LGTMです!

@YusukeKato YusukeKato merged commit 484796e into master Dec 12, 2024
11 checks passed
@YusukeKato YusukeKato deleted the fix/error_handling branch December 12, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Bug or Bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants