Skip to content

Conversation

juhi123
Copy link
Contributor

@juhi123 juhi123 commented Mar 19, 2019

  • Remove Phantom JS as it's deprecated
  • Added Chrome Driver
  • Update chrome

@PatelUtkarsh
Copy link
Contributor

@juhi123 are you working on this? I am thinking to remove test folder - https://github.com/rtCamp/nginx-helper/tree/master/tests/functional from repo until we hit green.

Let me know your thoughts.

@juhi123
Copy link
Contributor Author

juhi123 commented Apr 8, 2019

@PatelUtkarsh I was working on this but didn't get time. Test script is not working, needs to be updated.
Yes we can remove this until we hit green

PatelUtkarsh added a commit that referenced this pull request Apr 8, 2019
@PatelUtkarsh
Copy link
Contributor

@juhi123 I've removed tests in #196

You can use git revert 041e0e1 to restore test and there will be some conflicts with your PR since you've already modified it so you need to resolve that conflicts.

You can restore travis file using git revert aaa6c17.

@Vedant-Gandhi
Copy link
Contributor

Thank you for your contribution. Since the plugin no longer uses Travis, this PR is not required and will be closed.It has been removed in the following PR - #196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants