Skip to content

Improve irbrc loading order #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve irbrc loading order #808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3af0e5
Allow "project level" .irbrc to override previous definitions of .irbrc
ktopolski Dec 9, 2023
b2c12f8
Add test ensuring .irbrc loading order
ktopolski Dec 9, 2023
a0a2c50
Rename subdir to project_dir
ktopolski Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/irb/init.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,6 @@ def IRB.rc_file(ext = IRBRC_EXT)
@CONF[:RC_NAME_GENERATOR] ||= rcgen
if File.exist?(rcgen.call(IRBRC_EXT))
@CONF[:RC_NAME_GENERATOR] = rcgen
break
end
end
end
Expand Down
21 changes: 21 additions & 0 deletions test/irb/test_init.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,27 @@ def test_rc_file
end
end

def test_rc_file_loading_order
tmpdir = @tmpdir
Dir.chdir(tmpdir) do
# tmpdir is ENV["HOME"], so another dir is needed
project_dir = "#{tmpdir}/project"
FileUtils.mkdir_p(project_dir)
Dir.chdir(project_dir) do
ENV["XDG_CONFIG_HOME"] = "#{tmpdir}/xdg"
FileUtils.mkdir_p("#{tmpdir}/xdg/irb")
FileUtils.touch("#{tmpdir}/xdg/irb"+"/.irb#{IRB::IRBRC_EXT}")
# ENV["HOME"] .irbrc
FileUtils.touch(tmpdir+"/.irb#{IRB::IRBRC_EXT}")
# project level .irbrc
FileUtils.touch(project_dir+"/.irb#{IRB::IRBRC_EXT}")
IRB.conf[:RC_NAME_GENERATOR] = nil
assert_equal(project_dir+"/.irb#{IRB::IRBRC_EXT}", IRB.rc_file)
assert_equal(project_dir+"/.irb_history", IRB.rc_file("_history"))
end
end
end

def test_rc_file_in_subdir
tmpdir = @tmpdir
Dir.chdir(tmpdir) do
Expand Down