Skip to content

Conversation

@hatch01
Copy link

@hatch01 hatch01 commented Sep 18, 2025

I added the possibility to set the Ansible base directory at the project level.
This is very useful in my case where.
For each project I have a repo with playbooks and the rundeck jobs.
So the base dir is always the path to the scmImport folder.

Closes #271

Claude AI helped write this, so please feel free to correct me if I've missed anything.

Tests :
I created a basic project
Set the value project-wide and see it used in the jobs.
Set the value also in the job level and confirm the value is used instead of the project one.

Copilot AI review requested due to automatic review settings October 31, 2025 23:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the ansible-base-dir-path configuration property to be resolved from project and framework-level settings across all Ansible plugin types. Previously, this property could only be set at the job level.

Key changes:

  • Added property mappings for ANSIBLE_BASE_DIR_PATH to enable project and framework-level configuration resolution
  • Updated the getBaseDir() method to use PropertyResolver.resolveProperty() for consistent property resolution hierarchy
  • Added documentation for the ansible-base-dir-path configuration attribute

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
AnsiblePlaybookWorkflowStep.java Added mapping and framework mapping for ANSIBLE_BASE_DIR_PATH
AnsiblePlaybookWorflowNodeStep.java Added mapping and framework mapping for ANSIBLE_BASE_DIR_PATH
AnsiblePlaybookInlineWorkflowStep.java Added mapping and framework mapping for ANSIBLE_BASE_DIR_PATH
AnsiblePlaybookInlineWorkflowNodeStep.java Added mapping and framework mapping for ANSIBLE_BASE_DIR_PATH
AnsibleNodeExecutor.java Added mapping and framework mapping for ANSIBLE_BASE_DIR_PATH
AnsibleModuleWorkflowStep.java Added mapping and framework mapping for ANSIBLE_BASE_DIR_PATH
AnsibleRunnerContextBuilder.java Refactored getBaseDir() to use PropertyResolver for hierarchical property resolution
README.md Added documentation for the ansible-base-dir-path configuration attribute

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to set default directory for ansible source?

1 participant