Skip to content

Add serde/musli support to Source and Sources #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add serde/musli support to Source and Sources #951

wants to merge 13 commits into from

Conversation

@bloopos
Copy link

@bloopos bloopos commented Jun 18, 2025 •
edited
Loading

TODO

  • Write tests.

udoprog
udoprog requested changes Jun 19, 2025
View reviewed changes
Copy link
Collaborator

@udoprog udoprog left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the PR!

I'm not sure why we're writing manual implementations for musli encoding rather than deriving them. Could you elaborate on that?

Also approving the workflow run so we can see how the build goes.

@udoprog udoprog added the enhancement New feature or request label Jun 19, 2025
bloopos added 3 commits June 19, 2025 23:19
@bloopos
serde/musli test rewrite
1b01082 
Outside of a couple of revisions, serde/musli tests should run successfully.

Changelog:
    - Rewritten Encoding/Decoding tests
    - Added DecodedSourceInfo::build
    - For musli:
        - Auto-implemented Decode for DecodedSourceInfo
        - SourceInfo decoding now relies on decoding DecodedSourceInfo first
        - Decoding implementations, for SourceInfo, Source, and Sources, are now restricted
          to both Text and Binary mode
        - Auto-implemented Encode for both Sources and Source
    - For serde:
        -  (DecodedSourceInfo only) deserializing Box<str> uses a custom visitor to handle string values
@bloopos
Fixed test builds without feature
6c9037d
@bloopos
test: only implement PartialEq with either or enabled
4ef1582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@udoprog udoprog udoprog requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bloopos @udoprog